always select the next clients when autoaccepting shares #8570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
|
please backport to 4.x and 5.x |
2403905
approved these changes
Mar 4, 2024
|
kobergj
approved these changes
Mar 4, 2024
ownclouders
pushed a commit
that referenced
this pull request
Mar 4, 2024
…cept always select the next clients when autoaccepting shares
|
@micbar stable-4.0 does not support autoaccept. And we do not backport features, do we? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes autoaccepting shares when k8s decided to move the gateway pod
We need to pass down a selector and get a new client with Next(), right before the call.
Don't worry abouit the the Next() call itself. It stays in memory, as the registry uses a cache that is actively invalidated.